From: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Date: Mon, 6 Oct 2025 08:47:06 +0000 (+0530)
Subject: ACPI: button: Call input_free_device() on failing input device registration
X-Git-Tag: v6.18-rc4~21^2^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=20594cd104abaaabb676c7a2915b150ae5ff093d;p=thirdparty%2Fkernel%2Flinux.git

ACPI: button: Call input_free_device() on failing input device registration

Make acpi_button_add() call input_free_device() when
input_register_device() fails as required according to the
documentation of the latter.

Fixes: 0d51157dfaac ("ACPI: button: Eliminate the driver notify callback")
Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Cc: 6.5+ <stable@vger.kernel.org> # 6.5+
[ rjw: Subject and changelog rewrite, Fixes: tag ]
Link: https://patch.msgid.link/20251006084706.971855-1-kaushlendra.kumar@intel.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
index 0a70260401882..3c6dd9b4ba0ad 100644
--- a/drivers/acpi/button.c
+++ b/drivers/acpi/button.c
@@ -619,8 +619,10 @@ static int acpi_button_add(struct acpi_device *device)
 
 	input_set_drvdata(input, device);
 	error = input_register_device(input);
-	if (error)
+	if (error) {
+		input_free_device(input);
 		goto err_remove_fs;
+	}
 
 	switch (device->device_type) {
 	case ACPI_BUS_TYPE_POWER_BUTTON: