From: Dave Methvin <dave.methvin@gmail.com>
Date: Tue, 28 Jun 2016 01:41:00 +0000 (-0400)
Subject: Scrollspy test: Allow for async .then() in jQuery 3; fixes #20182
X-Git-Tag: v4.0.0-alpha.3~44
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=208d587c7ec0ea93c0d03c15d98952c8470af189;p=thirdparty%2Fbootstrap.git

Scrollspy test: Allow for async .then() in jQuery 3; fixes #20182

Instead of doing a new assert.async(), just do a single one for the entire test
and let the .then() be async as well.

Closes #20190
---

diff --git a/js/tests/unit/scrollspy.js b/js/tests/unit/scrollspy.js
index b04a9d8631..772fedc2ec 100644
--- a/js/tests/unit/scrollspy.js
+++ b/js/tests/unit/scrollspy.js
@@ -314,21 +314,21 @@ $(function () {
     var testElementIsActiveAfterScroll = function (element, target) {
       var deferred = $.Deferred()
       var scrollHeight = Math.ceil($content.scrollTop() + $(target).position().top)
-      var done = assert.async()
       $content.one('scroll', function () {
         assert.ok($(element).hasClass('active'), 'target:' + target + ', element: ' + element)
-        done()
         deferred.resolve()
       })
       $content.scrollTop(scrollHeight)
       return deferred.promise()
     }
 
+    var done = assert.async()
     $.when(testElementIsActiveAfterScroll('#li-100-5', '#div-100-5'))
       .then(function () { return testElementIsActiveAfterScroll('#li-100-4', '#div-100-4') })
       .then(function () { return testElementIsActiveAfterScroll('#li-100-3', '#div-100-3') })
       .then(function () { return testElementIsActiveAfterScroll('#li-100-2', '#div-100-2') })
       .then(function () { return testElementIsActiveAfterScroll('#li-100-1', '#div-100-1') })
+      .then(function () { done() })
   })
 
   QUnit.test('should allow passed in option offset method: offset', function (assert) {