From: Victor Julien <victor@inliniac.net>
Date: Thu, 17 Oct 2013 15:36:27 +0000 (+0200)
Subject: Fix broken check in stream.max-synack-queued parsing (coverity 1038103)
X-Git-Tag: suricata-2.0beta2~212
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=209946b07ca93588a8101648c1586897d9b007dd;p=thirdparty%2Fsuricata.git

Fix broken check in stream.max-synack-queued parsing (coverity 1038103)
---

diff --git a/src/stream-tcp.c b/src/stream-tcp.c
index 1d453dd96d..ac2f083ca5 100644
--- a/src/stream-tcp.c
+++ b/src/stream-tcp.c
@@ -442,7 +442,7 @@ void StreamTcpInitConfig(char quiet)
     }
 
     if ((ConfGetInt("stream.max-synack-queued", &value)) == 1) {
-        if (value >= 0 || value <= 255) {
+        if (value >= 0 && value <= 255) {
             stream_config.max_synack_queued = (uint8_t)value;
         } else {
             stream_config.max_synack_queued = (uint8_t)STREAMTCP_DEFAULT_MAX_SYNACK_QUEUED;