From: Theodore Ts'o <tytso@mit.edu>
Date: Mon, 25 Aug 2014 02:31:03 +0000 (-0400)
Subject: dumpe2fs: complain if extra arguments are given on the command line
X-Git-Tag: v1.42.12~21
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=20d6b381a1aacfdb553dcba95d96c5bf36ea7253;p=thirdparty%2Fe2fsprogs.git

dumpe2fs: complain if extra arguments are given on the command line

Addresses-Debian-Bug: #758074

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---

diff --git a/misc/dumpe2fs.c b/misc/dumpe2fs.c
index cc18ad835..1eae5a336 100644
--- a/misc/dumpe2fs.c
+++ b/misc/dumpe2fs.c
@@ -575,8 +575,10 @@ int main (int argc, char ** argv)
 			usage();
 		}
 	}
-	if (optind > argc - 1)
+	if (argc - 1 > optind) {
 		usage();
+		exit(1);
+	}
 	device_name = argv[optind++];
 	flags = EXT2_FLAG_JOURNAL_DEV_OK | EXT2_FLAG_SOFTSUPP_FEATURES | EXT2_FLAG_64BITS;
 	if (force)