From: Matt Caswell <matt@openssl.org>
Date: Mon, 29 Jan 2024 10:14:30 +0000 (+0000)
Subject: Fix compilation on Windows using icc
X-Git-Tag: openssl-3.3.0-alpha1~248
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=20ddfe78e9ddc0aba8208616e1b0b33cb12f77f5;p=thirdparty%2Fopenssl.git

Fix compilation on Windows using icc

The parameter list for CRYPTO_DOWN_REF for the icc on windows build was
incorrect.

This issue was introduced by 99fd5b2b10

Fixes #23414

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/23415)
---

diff --git a/include/internal/refcount.h b/include/internal/refcount.h
index 4c9ab266d3d..d23bbb9eb98 100644
--- a/include/internal/refcount.h
+++ b/include/internal/refcount.h
@@ -101,7 +101,7 @@ static __inline int CRYPTO_UP_REF(CRYPTO_REF_COUNT *refcnt, int *ret)
     return 1;
 }
 
-static __inline int CRYPTO_DOWN_REF(CRYPTO_REF_COUNT *val, int *refcnt)
+static __inline int CRYPTO_DOWN_REF(CRYPTO_REF_COUNT *refcnt, int *ret)
 {
     *ret = _InterlockedExchangeAdd((void *)&refcnt->val, -1) - 1;
     return 1;