From: Jim Meyering <meyering@redhat.com>
Date: Thu, 3 Sep 2009 10:12:19 +0000 (+0200)
Subject: test.c: don't use undefined local, "def"
X-Git-Tag: v0.7.1~114
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=20f1f714ba4babd7b57f2b4a2657e9e58c60efc0;p=thirdparty%2Flibvirt.git

test.c: don't use undefined local, "def"

* src/test.c (testOpenVolumesForPool): Upon early virAsprintf or
virXPathNodeSet failure, "goto error" would take us to
virStorageVolDefFree(def), but with "def" not defined.
Initialize it to NULL.
---

diff --git a/src/test.c b/src/test.c
index 7c8f85b0ea..895cce1084 100644
--- a/src/test.c
+++ b/src/test.c
@@ -435,7 +435,7 @@ static int testOpenVolumesForPool(virConnectPtr conn,
     char *vol_xpath;
     int i, ret, func_ret = -1;
     xmlNodePtr *vols = NULL;
-    virStorageVolDefPtr def;
+    virStorageVolDefPtr def = NULL;
 
     /* Find storage volumes */
     if (virAsprintf(&vol_xpath, "/node/pool[%d]/volume", poolidx) < 0) {