From: Rico Tzschichholz <ricotz@ubuntu.com>
Date: Tue, 11 Oct 2016 13:21:41 +0000 (+0200)
Subject: codegen: Trigger deprecation warning for NoArrayLength from a better place
X-Git-Tag: 0.35.1~95
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=213cec89aa3dcb234e3d41437adb99e7171e4a4b;p=thirdparty%2Fvala.git

codegen: Trigger deprecation warning for NoArrayLength from a better place
---

diff --git a/codegen/valaccodeattribute.vala b/codegen/valaccodeattribute.vala
index f9c9ab6e7..d7cb20059 100644
--- a/codegen/valaccodeattribute.vala
+++ b/codegen/valaccodeattribute.vala
@@ -473,7 +473,7 @@ public class Vala.CCodeAttribute : AttributeCache {
 		get {
 			if (_array_length == null) {
 				if (node.get_attribute ("NoArrayLength") != null) {
-					// deprecated
+					Report.deprecated (node.source_reference, "[NoArrayLength] is deprecated, use [CCode (array_length = false)] instead.");
 					_array_length = false;
 				} else if (ccode != null && ccode.has_argument ("array_length")) {
 					_array_length = ccode.get_bool ("array_length");
diff --git a/codegen/valaccodemethodmodule.vala b/codegen/valaccodemethodmodule.vala
index aa2ab5c8c..9c8e92136 100644
--- a/codegen/valaccodemethodmodule.vala
+++ b/codegen/valaccodemethodmodule.vala
@@ -306,10 +306,6 @@ public abstract class Vala.CCodeMethodModule : CCodeStructModule {
 
 		bool profile = m.get_attribute ("Profile") != null;
 
-		if (m.get_attribute ("NoArrayLength") != null) {
-			Report.deprecated (m.source_reference, "NoArrayLength attribute is deprecated, use [CCode (array_length = false)] instead.");
-		}
-
 		if (m is CreationMethod) {
 			var cl = current_type_symbol as Class;
 			if (cl != null && !cl.is_compact) {
diff --git a/vala/valausedattr.vala b/vala/valausedattr.vala
index 14cdd97b9..14fe1d20b 100644
--- a/vala/valausedattr.vala
+++ b/vala/valausedattr.vala
@@ -48,6 +48,7 @@ public class Vala.UsedAttr : CodeVisitor {
 		"Flags", "",
 		"Experimental", "",
 		"NoReturn", "",
+		"NoArrayLength", "", // deprecated
 		"Assert", "",
 		"ErrorBase", "",
 		"GenericAccessors", "",