From: Victor Julien <victor@inliniac.net>
Date: Fri, 20 May 2016 16:42:46 +0000 (+0200)
Subject: coverity: CID 1362012: Incorrect expression (EVALUATION_ORDER)
X-Git-Tag: suricata-3.1RC1~91
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=213f041c977c23710b986926433dfdf545e54814;p=thirdparty%2Fsuricata.git

coverity: CID 1362012: Incorrect expression (EVALUATION_ORDER)
---

diff --git a/src/app-layer-smtp.c b/src/app-layer-smtp.c
index 3f80d3e37a..8bdb1f54ff 100644
--- a/src/app-layer-smtp.c
+++ b/src/app-layer-smtp.c
@@ -374,7 +374,7 @@ static void SMTPPruneFiles(FileContainer *files)
                 window, file_size, data_size);
 
         if (data_size > (window * 3)) {
-            uint64_t left_edge = left_edge = file_size - window;
+            uint64_t left_edge = file_size - window;
             SCLogDebug("file->content_inspected now %"PRIu64, left_edge);
             file->content_inspected = left_edge;
         }