From: Mark Andrews <marka@isc.org>
Date: Mon, 19 Nov 2018 20:23:37 +0000 (+1100)
Subject: address coverity side effect in assert warning
X-Git-Tag: v9.13.5~37^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2156a5b6107cb3e804109dab15232ee97d3800d8;p=thirdparty%2Fbind9.git

address coverity side effect in assert warning
---

diff --git a/lib/dns/tests/name_test.c b/lib/dns/tests/name_test.c
index 4974eea81d7..0555345354a 100644
--- a/lib/dns/tests/name_test.c
+++ b/lib/dns/tests/name_test.c
@@ -606,7 +606,6 @@ getlabel_test(void **state) {
 		dns_fixedname_t f1, f2;
 		dns_name_t *n1, *n2;
 		dns_label_t l1, l2;
-		unsigned char *p1, *p2;
 		unsigned int j;
 
 		n1 = dns_fixedname_initname(&f1);
@@ -623,10 +622,8 @@ getlabel_test(void **state) {
 		dns_name_getlabel(n2, testcases[i].pos2, &l2);
 		assert_int_equal(l1.length, l2.length);
 
-		p1 = l1.base;
-		p2 = l2.base;
 		for (j = 0; j < l1.length; j++) {
-			assert_int_equal(*p1++, *p2++);
+			assert_int_equal(l1.base[j], l2.base[j]);
 		}
 	}
 }