From: Cole Robinson <crobinso@redhat.com>
Date: Tue, 17 Apr 2018 16:44:56 +0000 (-0400)
Subject: conf: Add a comment warning about boolean feature XML
X-Git-Tag: v4.4.0-rc1~313
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=217d2656a552cf079fa26154121774d6dd7f0249;p=thirdparty%2Flibvirt.git

conf: Add a comment warning about boolean feature XML

This is the old style and we really shouldn't be adding any more
examples like this. Add a comment to warn devs away

Reviewed-by: John Ferlan <jferlan@redhat.com>
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index c92725dd25..4e2de46d45 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -26894,6 +26894,8 @@ virDomainDefFormatInternal(virDomainDefPtr def,
             case VIR_DOMAIN_FEATURE_PAE:
             case VIR_DOMAIN_FEATURE_VIRIDIAN:
             case VIR_DOMAIN_FEATURE_PRIVNET:
+                /* NOTE: This is for old style <opt/> booleans. New XML
+                 * should use the explicit state=on|off output below */
                 switch ((virTristateSwitch) def->features[i]) {
                 case VIR_TRISTATE_SWITCH_ABSENT:
                     break;