From: Thomas Weißschuh Date: Thu, 14 May 2026 12:05:13 +0000 (+0200) Subject: tools/nolibc: always pass mode to open syscall X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=219d120c195e53dd33076be05641fda0e36bff37;p=thirdparty%2Flinux.git tools/nolibc: always pass mode to open syscall When O_TMPFILE is set, the open mode needs to be passed to the kernel as per the documentation. Currently this is not done. Instead of checking for O_TMPFILE explicitly and making the conditionals more complex, just always pass the mode to the kernel. If no value was passed the mode will be garbage, but the kernel will ignore it anyways. Fixes: a7604ba149e7 ("tools/nolibc/sys: make open() take a vararg on the 3rd argument") Suggested-by: Willy Tarreau Link: https://lore.kernel.org/lkml/afRfjdovT6pNtwtP@1wt.eu/ Signed-off-by: Thomas Weißschuh Acked-by: Willy Tarreau Link: https://patch.msgid.link/20260514-nolibc-open-tmpfile-v2-3-b4c6c5efa266@weissschuh.net --- diff --git a/tools/include/nolibc/fcntl.h b/tools/include/nolibc/fcntl.h index d7ea02e1332d8..d4b6af60d4cc0 100644 --- a/tools/include/nolibc/fcntl.h +++ b/tools/include/nolibc/fcntl.h @@ -18,15 +18,12 @@ #define __nolibc_open_mode(_flags) \ ({ \ - mode_t _mode = 0; \ + mode_t _mode; \ + va_list args; \ \ - if ((_flags) & O_CREAT) { \ - va_list args; \ - \ - va_start(args, (_flags)); \ - _mode = va_arg(args, mode_t); \ - va_end(args); \ - } \ + va_start(args, (_flags)); \ + _mode = va_arg(args, mode_t); \ + va_end(args); \ \ _mode; \ })