From: Ján Tomko Date: Thu, 28 Mar 2019 13:11:23 +0000 (+0100) Subject: Revert "qemu: emit error when trying to update blkiotune group_name in qemuDomainChan... X-Git-Tag: v5.2.0-rc2~3 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=21a9cb986cca8cb5d3b640a94a881392823d7f2a;p=thirdparty%2Flibvirt.git Revert "qemu: emit error when trying to update blkiotune group_name in qemuDomainChangeDiskLive" https://bugzilla.redhat.com/show_bug.cgi?id=1601677 This reverts commit 047cfb05ee949325e77726531fd381820be8dc62 Using numeric comparison on strings means we reject every update that does include the group name, even if it's unchanged. Signed-off-by: Ján Tomko Reviewed-by: Laine Stump --- diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 54afb6dd7b..7e0938e989 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -9385,9 +9385,6 @@ qemuDomainDiskChangeSupported(virDomainDiskDefPtr disk, CHECK_EQ(blkdeviotune.size_iops_sec, "blkdeviotune size_iops_sec", true); - CHECK_EQ(blkdeviotune.group_name, - "blkdeviotune group_name", - true); if (disk->serial && STRNEQ_NULLABLE(disk->serial, orig_disk->serial)) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED,