From: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: Tue, 28 Oct 2025 05:41:46 +0000 (+0100)
Subject: target/arm/hvf: Mention hvf_arch_set_traps() must run on vCPU thread
X-Git-Tag: v10.2.0-rc1~28^2~20
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=21bab557a9ad3209552321789c9feb4b5ad1c437;p=thirdparty%2Fqemu.git

target/arm/hvf: Mention hvf_arch_set_traps() must run on vCPU thread

Since hvf_arch_set_traps() calls hv_vcpu_set_trap_debug_exceptions()
and hv_vcpu_set_trap_debug_reg_accesses(), which must run on a vCPU,
it also must. Mention it.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Mads Ynddal <mads@ynddal.dk>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---

diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c
index bfccf5e9a2..ee04943b0f 100644
--- a/target/arm/hvf/hvf.c
+++ b/target/arm/hvf/hvf.c
@@ -2192,6 +2192,7 @@ static inline bool hvf_arm_hw_debug_active(CPUState *cpu)
     return ((cur_hw_wps > 0) || (cur_hw_bps > 0));
 }
 
+/* Must be called by the owning thread */
 static void hvf_arch_set_traps(CPUState *cpu)
 {
     bool should_enable_traps = false;