From: Jason Ish <jason.ish@oisf.net>
Date: Fri, 14 Oct 2022 17:59:20 +0000 (-0600)
Subject: rust: fix clippy lint for unneeded late initialization
X-Git-Tag: suricata-7.0.0-beta1~24
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=21bb697bc98fc5c99788e0947d55f22125decd8f;p=thirdparty%2Fsuricata.git

rust: fix clippy lint for unneeded late initialization
---

diff --git a/rust/src/smb/debug.rs b/rust/src/smb/debug.rs
index 15d8748c0a..3f706a09fc 100644
--- a/rust/src/smb/debug.rs
+++ b/rust/src/smb/debug.rs
@@ -42,14 +42,13 @@ impl SMBState {
         for i in 0..len {
             let tx = &self.transactions[i];
             let ver = tx.vercmd.get_version();
-            let _smbcmd;
-            if ver == 2 {
+            let _smbcmd = if ver == 2 {
                 let (_, cmd) = tx.vercmd.get_smb2_cmd();
-                _smbcmd = cmd;
+                cmd
             } else {
                 let (_, cmd) = tx.vercmd.get_smb1_cmd();
-                _smbcmd = cmd as u16;
-            }
+                cmd as u16
+            };
 
             match tx.type_data {
                 Some(SMBTransactionTypeData::FILE(ref d)) => {