From: Corey Farrell Date: Sun, 9 Nov 2014 08:01:18 +0000 (+0000) Subject: manager: Fix HTTP connection reference leaks. X-Git-Tag: 14.0.0-beta1~1474 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=21c41e4542290747bf90d8086f60c39030367ff9;p=thirdparty%2Fasterisk.git manager: Fix HTTP connection reference leaks. Fix reference leak that happens if (session && !blastaway). ASTERISK-24505 #close Reported by: Corey Farrell Review: https://reviewboard.asterisk.org/r/4153/ ........ Merged revisions 427641 from http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged revisions 427642 from http://svn.asterisk.org/svn/asterisk/branches/12 ........ Merged revisions 427643 from http://svn.asterisk.org/svn/asterisk/branches/13 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@427644 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- diff --git a/main/manager.c b/main/manager.c index ceee37f31e..6fe12c50d7 100644 --- a/main/manager.c +++ b/main/manager.c @@ -7515,11 +7515,16 @@ generic_callback_out: ast_free(http_header); ast_free(out); - if (session && blastaway) { - session_destroy(session); - } else if (session && session->f) { - fclose(session->f); - session->f = NULL; + if (session) { + if (blastaway) { + session_destroy(session); + } else { + if (session->f) { + fclose(session->f); + session->f = NULL; + } + unref_mansession(session); + } } return 0;