From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Thu, 10 Aug 2017 13:28:24 +0000 (+0200)
Subject: Remove duplicate setting of attr
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=21da31c2b24acc18f48ca245d26aa76f44dde5c3;p=thirdparty%2Ffreeradius-server.git

Remove duplicate setting of attr

Check there’s a reply packet?
---

diff --git a/src/modules/rlm_radius/rlm_radius_udp.c b/src/modules/rlm_radius/rlm_radius_udp.c
index dfa85322d3d..cbd8af5770d 100644
--- a/src/modules/rlm_radius/rlm_radius_udp.c
+++ b/src/modules/rlm_radius/rlm_radius_udp.c
@@ -559,7 +559,6 @@ redo:
 	if (code == FR_CODE_PROTOCOL_ERROR) {
 		uint8_t const *attr, *end;
 
-		attr = c->buffer + 20;
 		end = c->buffer + packet_len;
 		link->rcode = RLM_MODULE_INVALID;
 
@@ -677,7 +676,7 @@ redo:
 		 *	Access-Accept" policies...  so the user could
 		 *	programatically decide which attributes to add.
 		 */
-		
+
 		fr_pair_add(&request->reply->vps, vp);
 	}
 
@@ -691,7 +690,7 @@ done:
 		 *	Delete the reply, but leave the request VPs in
 		 *	place.
 		 */
-		fr_pair_list_free(&request->reply->vps);
+		if (request->reply) fr_pair_list_free(&request->reply->vps);
 
 	} else {
 		/*