From: Sergey Miryanov Date: Sat, 15 Nov 2025 18:56:52 +0000 (+0500) Subject: [3.14] GH-141509: Fix warning about remaining subinterpreters (GH-141528) (GH-141566) X-Git-Tag: v3.14.1~111 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=21e43d5e8343f356f12d6450a00b3c1e66f66bab;p=thirdparty%2FPython%2Fcpython.git [3.14] GH-141509: Fix warning about remaining subinterpreters (GH-141528) (GH-141566) (cherry picked from commit fa245df4a0848c15cf8d907c10fc92819994b866) Co-authored-by: Peter Bierma --- diff --git a/Lib/test/test_interpreters/test_api.py b/Lib/test/test_interpreters/test_api.py index c5a1743e7fde..e88fd399dfba 100644 --- a/Lib/test/test_interpreters/test_api.py +++ b/Lib/test/test_interpreters/test_api.py @@ -431,6 +431,7 @@ class InterpreterObjectTests(TestBase): exit()""" stdout, stderr = repl.communicate(script) self.assertIsNone(stderr) + self.assertIn(b"Interpreter.close()", stdout) self.assertNotIn(b"Traceback", stdout) diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2025-11-14-00-19-45.gh-issue-141528.VWdax1.rst b/Misc/NEWS.d/next/Core_and_Builtins/2025-11-14-00-19-45.gh-issue-141528.VWdax1.rst new file mode 100644 index 000000000000..a51aa4952286 --- /dev/null +++ b/Misc/NEWS.d/next/Core_and_Builtins/2025-11-14-00-19-45.gh-issue-141528.VWdax1.rst @@ -0,0 +1,3 @@ +Suggest using :meth:`concurrent.interpreters.Interpreter.close` instead of the +private ``_interpreters.destroy`` function when warning about remaining subinterpreters. +Patch by Sergey Miryanov. diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c index 5b9ce617a486..f5fbdeedac34 100644 --- a/Python/pylifecycle.c +++ b/Python/pylifecycle.c @@ -2517,7 +2517,7 @@ finalize_subinterpreters(void) (void)PyErr_WarnEx( PyExc_RuntimeWarning, "remaining subinterpreters; " - "destroy them with _interpreters.destroy()", + "close them with Interpreter.close()", 0); /* Swap out the current tstate, which we know must belong