From: Jouni Malinen <j@w1.fi>
Date: Sat, 7 May 2022 21:31:25 +0000 (+0300)
Subject: DPP: Verify that crypto_ec_point_to_bin() succeeds
X-Git-Tag: hostap_2_11~1923
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2227c85a940277e01a46f2c02fcc6c4df7a61ec6;p=thirdparty%2Fhostap.git

DPP: Verify that crypto_ec_point_to_bin() succeeds

This is testing code, but it's better to check the return value
explicitly even if this were not really able to fail in practice.

Signed-off-by: Jouni Malinen <j@w1.fi>
---

diff --git a/src/common/dpp_crypto.c b/src/common/dpp_crypto.c
index 47f56c258..8d3f3abfa 100644
--- a/src/common/dpp_crypto.c
+++ b/src/common/dpp_crypto.c
@@ -2472,11 +2472,9 @@ retry:
 
 	/* Retrieve public key coordinates */
 	pub_key = crypto_ec_key_get_public_key(key);
-	if (!pub_key)
+	if (!pub_key || crypto_ec_point_to_bin(ec, pub_key, x, y))
 		goto fail;
 
-	crypto_ec_point_to_bin(ec, pub_key, x, y);
-
 	/* And corrupt them */
 	y[curve->prime_len - 1] ^= 0x01;
 	p = crypto_ec_point_from_bin(ec, x);