From: Mark Michelson Date: Fri, 25 Jul 2008 14:40:52 +0000 (+0000) Subject: Merged revisions 133572 via svnmerge from X-Git-Tag: 1.6.2.0-beta1~1589 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=223c04ec530380531249267752fb848e1332db75;p=thirdparty%2Fasterisk.git Merged revisions 133572 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r133572 | mmichelson | 2008-07-25 09:40:10 -0500 (Fri, 25 Jul 2008) | 7 lines We need to make sure to null-terminate the "name" portion of SIP URI parameters so that there are no bogus comparisons. Thanks to bbryant for pointing this out. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@133573 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- diff --git a/channels/chan_sip.c b/channels/chan_sip.c index 55d5d97afc..89cf846cf9 100644 --- a/channels/chan_sip.c +++ b/channels/chan_sip.c @@ -16805,6 +16805,7 @@ static int sip_uri_params_cmp(const char *input1, const char *input2) if (!value2) { goto fail; } + *value2++ = '\0'; if (!strcasecmp(name1, name2)) { if (strcasecmp(value1, value2)) { goto fail; @@ -16859,6 +16860,7 @@ static int sip_uri_params_cmp(const char *input1, const char *input2) if (!value2) { goto fail; } + *value2++ = '\0'; if ((!strcasecmp(name2, "maddr") && !maddrmatch) || (!strcasecmp(name2, "ttl") && !ttlmatch) || (!strcasecmp(name2, "user") && !usermatch) ||