From: Alexandre Oliva Date: Fri, 28 Feb 2014 12:57:06 +0000 (+0000) Subject: re PR debug/59992 (Compilation of insn-recog.c too slow due to var-tracking) X-Git-Tag: releases/gcc-4.9.0~632 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=22414f3ffcc916cf5fdaa5d3b0d180c197b6d848;p=thirdparty%2Fgcc.git re PR debug/59992 (Compilation of insn-recog.c too slow due to var-tracking) PR debug/59992 * cselib.c (remove_useless_values): Skip to avoid quadratic behavior if the condition moved from... (cselib_process_insn): ... here holds. From-SVN: r208220 --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 51c270614de9..0ea85dcecf64 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2014-02-28 Alexandre Oliva + + PR debug/59992 + * cselib.c (remove_useless_values): Skip to avoid quadratic + behavior if the condition moved from... + (cselib_process_insn): ... here holds. + 2014-02-28 Alexandre Oliva PR debug/57232 diff --git a/gcc/cselib.c b/gcc/cselib.c index 525e717c6338..dabd2d32f634 100644 --- a/gcc/cselib.c +++ b/gcc/cselib.c @@ -662,6 +662,14 @@ remove_useless_values (void) { cselib_val **p, *v; + if (n_useless_values <= MAX_USELESS_VALUES + /* remove_useless_values is linear in the hash table size. Avoid + quadratic behavior for very large hashtables with very few + useless elements. */ + || ((unsigned int)n_useless_values + <= (cselib_hash_table.elements () - n_debug_values) / 4)) + return; + /* First pass: eliminate locations that reference the value. That in turn can make more values useless. */ do @@ -2693,13 +2701,7 @@ cselib_process_insn (rtx insn) cselib_current_insn = NULL_RTX; - if (n_useless_values > MAX_USELESS_VALUES - /* remove_useless_values is linear in the hash table size. Avoid - quadratic behavior for very large hashtables with very few - useless elements. */ - && ((unsigned int)n_useless_values - > (cselib_hash_table.elements () - n_debug_values) / 4)) - remove_useless_values (); + remove_useless_values (); } /* Initialize cselib for one pass. The caller must also call