From: Kohei Yoshino Date: Tue, 9 Jan 2018 22:42:57 +0000 (-0500) Subject: Bug 1429194 - Clicking requests icon gives "Loading... " but never actually completes X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=22467136063067ad0a5cf442be67691fc296ce31;p=thirdparty%2Fbugzilla.git Bug 1429194 - Clicking requests icon gives "Loading... " but never actually completes --- diff --git a/extensions/Review/web/js/badge.js b/extensions/Review/web/js/badge.js index d22ca4e57..f5f8cc236 100644 --- a/extensions/Review/web/js/badge.js +++ b/extensions/Review/web/js/badge.js @@ -76,8 +76,8 @@ Bugzilla.Review.Badge = class Badge { // Show up to 20 newest requests requests.slice(0, 20).forEach(req => { const $li = document.createElement('li'); - const [, name, email] = req.requester.match(/^(.*)\s<(.*)>$/); - const pretty_name = name.replace(/([\[\(<‹].*?[›>\)\]]|\:[\w\-]+|\s+\-\s+.*)/g, '').trim(); + const [, name, email] = req.requester.match(/^(?:(.*)\s<)?(.+?)>?$/); + const pretty_name = name ? name.replace(/([\[\(<‹].*?[›>\)\]]|\:[\w\-]+|\s+\-\s+.*)/g, '').trim() : email; const link = req.attach_id && req.dup_count === 1 ? `attachment.cgi?id=${req.attach_id}&action=edit` : `show_bug.cgi?id=${req.bug_id}`;