From: Bob Halley <halley@dnspython.org>
Date: Tue, 4 Aug 2020 13:44:06 +0000 (-0700)
Subject: lint
X-Git-Tag: v2.1.0rc1~109
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=224dd115771dc0bc90e4fe1b9e5f824a400c6317;p=thirdparty%2Fdnspython.git

lint
---

diff --git a/Makefile b/Makefile
index ff511501..2e120ae9 100644
--- a/Makefile
+++ b/Makefile
@@ -59,7 +59,7 @@ potype:
 	poetry run python -m mypy examples tests dns/*.py
 
 polint:
-	poetry run pylint dns/*.py
+	poetry run pylint dns
 
 poflake:
 	poetry run flake8 dns
diff --git a/dns/rdtypes/ANY/CDNSKEY.py b/dns/rdtypes/ANY/CDNSKEY.py
index 72253183..a8b1d8ba 100644
--- a/dns/rdtypes/ANY/CDNSKEY.py
+++ b/dns/rdtypes/ANY/CDNSKEY.py
@@ -16,8 +16,10 @@
 # OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 
 import dns.rdtypes.dnskeybase
-from dns.rdtypes.dnskeybase import SEP, REVOKE, ZONE  # noqa: F401
 
+# pylint: disable=unused-import
+from dns.rdtypes.dnskeybase import SEP, REVOKE, ZONE  # noqa: F401
+# pylint: enable=unused-import
 
 class CDNSKEY(dns.rdtypes.dnskeybase.DNSKEYBase):
 
diff --git a/dns/rdtypes/ANY/DNSKEY.py b/dns/rdtypes/ANY/DNSKEY.py
index 2ee37988..7173b414 100644
--- a/dns/rdtypes/ANY/DNSKEY.py
+++ b/dns/rdtypes/ANY/DNSKEY.py
@@ -16,8 +16,10 @@
 # OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 
 import dns.rdtypes.dnskeybase
-from dns.rdtypes.dnskeybase import SEP, REVOKE, ZONE  # noqa: F401
 
+# pylint: disable=unused-import
+from dns.rdtypes.dnskeybase import SEP, REVOKE, ZONE  # noqa: F401
+# pylint: enable=unused-import
 
 class DNSKEY(dns.rdtypes.dnskeybase.DNSKEYBase):
 
diff --git a/dns/rdtypes/ANY/OPT.py b/dns/rdtypes/ANY/OPT.py
index c48aa12f..5d86d828 100644
--- a/dns/rdtypes/ANY/OPT.py
+++ b/dns/rdtypes/ANY/OPT.py
@@ -22,6 +22,9 @@ import dns.exception
 import dns.rdata
 
 
+# We don't implement from_text, and that's ok.
+# pylint: disable=abstract-method
+
 class OPT(dns.rdata.Rdata):
 
     """OPT record"""
diff --git a/dns/rdtypes/ANY/TSIG.py b/dns/rdtypes/ANY/TSIG.py
index 18db4c9e..537f9c34 100644
--- a/dns/rdtypes/ANY/TSIG.py
+++ b/dns/rdtypes/ANY/TSIG.py
@@ -21,6 +21,9 @@ import dns.exception
 import dns.rdata
 
 
+# We don't implement from_text, and that's ok.
+# pylint: disable=abstract-method
+
 class TSIG(dns.rdata.Rdata):
 
     """TSIG record"""
diff --git a/dns/rdtypes/IN/NAPTR.py b/dns/rdtypes/IN/NAPTR.py
index a861b67f..f45262ca 100644
--- a/dns/rdtypes/IN/NAPTR.py
+++ b/dns/rdtypes/IN/NAPTR.py
@@ -87,7 +87,7 @@ class NAPTR(dns.rdata.Rdata):
     def from_wire_parser(cls, rdclass, rdtype, parser, origin=None):
         (order, preference) = parser.get_struct('!HH')
         strings = []
-        for i in range(3):
+        for _ in range(3):
             s = parser.get_counted_bytes()
             strings.append(s)
         replacement = parser.get_name(origin)
diff --git a/dns/rdtypes/IN/WKS.py b/dns/rdtypes/IN/WKS.py
index 9b5e87e6..75444fb5 100644
--- a/dns/rdtypes/IN/WKS.py
+++ b/dns/rdtypes/IN/WKS.py
@@ -74,7 +74,7 @@ class WKS(dns.rdata.Rdata):
             i = serv // 8
             l = len(bitmap)
             if l < i + 1:
-                for j in range(l, i + 1):
+                for _ in range(l, i + 1):
                     bitmap.append(0)
             bitmap[i] = bitmap[i] | (0x80 >> (serv % 8))
         bitmap = dns.rdata._truncate_bitmap(bitmap)
diff --git a/dns/rdtypes/util.py b/dns/rdtypes/util.py
index 3a089ed2..bac7e7a7 100644
--- a/dns/rdtypes/util.py
+++ b/dns/rdtypes/util.py
@@ -68,6 +68,7 @@ class Gateway:
         else:
             raise dns.exception.SyntaxError(self._invalid_type())
 
+    # pylint: disable=unused-argument
     def to_wire(self, file, compress=None, origin=None, canonicalize=False):
         if self.type == 0:
             pass
@@ -79,6 +80,7 @@ class Gateway:
             self.gateway.to_wire(file, None, origin, False)
         else:
             raise ValueError(self._invalid_type())
+    # pylint: enable=unused-argument
 
     def from_wire_parser(self, parser, origin=None):
         if self.type == 0: