From: Aurelien Jarno Date: Wed, 15 Dec 2021 23:06:28 +0000 (+0100) Subject: riscv: align stack before calling _dl_init [BZ #28703] X-Git-Tag: glibc-2.35~220 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=225da459cebef1037dcd78b56471edc0721e1c41;p=thirdparty%2Fglibc.git riscv: align stack before calling _dl_init [BZ #28703] Align the stack pointer to 128 bits during the call to _dl_init() as specified by the RISC-V ABI [1]. This fixes the elf/tst-align2 test. Fixes bug 28703. [1] https://github.com/riscv-non-isa/riscv-elf-psabi-doc --- diff --git a/sysdeps/riscv/dl-machine.h b/sysdeps/riscv/dl-machine.h index ce2b3c3875d..f457a41c70e 100644 --- a/sysdeps/riscv/dl-machine.h +++ b/sysdeps/riscv/dl-machine.h @@ -125,8 +125,14 @@ elf_machine_dynamic (void) sll a3, a1, " STRINGXP (PTRLOG) "\n\ add a3, a3, a2\n\ add a3, a3, " STRINGXP (SZREG) "\n\ + # Stash the stack pointer in s1.\n\ + mv s1, sp\n\ + # Align stack to 128 bits for the _dl_init call.\n\ + andi sp, sp,-16\n\ # Call the function to run the initializers.\n\ jal _dl_init\n\ + # Restore the stack pointer for _start.\n\ + mv sp, s1\n\ # Pass our finalizer function to _start.\n\ lla a0, _dl_fini\n\ # Jump to the user entry point.\n\