From: Franck Bui <fbui@suse.com>
Date: Tue, 24 Sep 2019 16:54:15 +0000 (+0200)
Subject: shared/install: failing with -ELOOP can be due to the use of an alias in install_error()
X-Git-Tag: v244-rc1~150^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=22683674716fd0e5b016ce5a7d8fd90df5f9f9e7;p=thirdparty%2Fsystemd.git

shared/install: failing with -ELOOP can be due to the use of an alias in install_error()

-ELOOP can happen also when enabling an alias name (which is admittedly useless
since the unit it belongs to was already enabled) so let's mention this
possibility when reporting the corresponding error.
---

diff --git a/src/core/dbus-manager.c b/src/core/dbus-manager.c
index 035011e34f9..98d2e828a3f 100644
--- a/src/core/dbus-manager.c
+++ b/src/core/dbus-manager.c
@@ -1903,11 +1903,13 @@ static int install_error(
 
                 case -ELOOP:
                         r = sd_bus_error_setf(error, BUS_ERROR_UNIT_LINKED,
-                                              "Refusing to operate on linked unit file %s", changes[i].path);
+                                              "Refusing to operate on alias name or linked unit file: %s",
+                                              changes[i].path);
                         goto found;
 
                 case -ENOENT:
-                        r = sd_bus_error_setf(error, BUS_ERROR_NO_SUCH_UNIT, "Unit file %s does not exist.", changes[i].path);
+                        r = sd_bus_error_setf(error, BUS_ERROR_NO_SUCH_UNIT,
+                                              "Unit file %s does not exist.", changes[i].path);
                         goto found;
 
                 default: