From: Michal Privoznik <mprivozn@redhat.com>
Date: Fri, 21 Apr 2023 08:06:10 +0000 (+0200)
Subject: qemuhotplugtest: Don't overwrite vm->def->id in testQemuHotplugCheckResult()
X-Git-Tag: v9.3.0-rc1~21
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=22c082b8a2cf54421a689368a218cd5cf5ef4d3f;p=thirdparty%2Flibvirt.git

qemuhotplugtest: Don't overwrite vm->def->id in testQemuHotplugCheckResult()

This is a leftover from v2.0.0-rc1~300. In v1.2.12-rc1~43 we've
introduced a code that explicitly sets vm->def->id to -1 to force
generation of inactive XML. But this was removed in the later
commit, which forgot to remove the restoration of the original
dom ID.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Kristina Hanicova <khanicov@redhat.com>
---

diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c
index 635f5a39bd..0794a0c9a4 100644
--- a/tests/qemuhotplugtest.c
+++ b/tests/qemuhotplugtest.c
@@ -122,7 +122,6 @@ testQemuHotplugCheckResult(virDomainObj *vm,
                                 VIR_DOMAIN_DEF_FORMAT_SECURE);
     if (!actual)
         return -1;
-    vm->def->id = QEMU_HOTPLUG_TEST_DOMAIN_ID;
 
     if (STREQ(expected, actual)) {
         if (fail)