From: Dave Lawrence <dlawrence@mozilla.com>
Date: Fri, 17 Jan 2014 06:11:55 +0000 (-0500)
Subject: Bug 960748 - Queries involving comment tags crash
X-Git-Tag: bugzilla-4.5.2~29
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=22c96de30e07d73456cb336896f9c483f8790b8d;p=thirdparty%2Fbugzilla.git

Bug 960748 - Queries involving comment tags crash
r/a=glob
---

diff --git a/Bugzilla/Search.pm b/Bugzilla/Search.pm
index b196fca3b1..b9946889d0 100644
--- a/Bugzilla/Search.pm
+++ b/Bugzilla/Search.pm
@@ -307,7 +307,8 @@ use constant OPERATOR_FIELD_OVERRIDE => {
         _non_changed => \&_product_nonchanged,
     },
     tag => MULTI_SELECT_OVERRIDE,
-    
+    comment_tag => MULTI_SELECT_OVERRIDE,
+
     # Timetracking Fields
     deadline => { _non_changed => \&_deadline },
     percentage_complete => {
@@ -2867,6 +2868,13 @@ sub _multiselect_table {
         return "attachments INNER JOIN attach_data "
                . " ON attachments.attach_id = attach_data.id"
     }
+    elsif ($field eq 'comment_tag') {
+        $args->{_extra_where} = " AND longdescs.isprivate = 0"
+            if !$self->_user->is_insider;
+        $args->{full_field} = 'longdescs_tags.tag';
+        return "longdescs INNER JOIN longdescs_tags".
+               " ON longdescs.comment_id = longdescs_tags.comment_id";
+    }
     my $table = "bug_$field";
     $args->{full_field} = "bug_$field.value";
     return $table;