From: Michael Tremer <michael.tremer@ipfire.org>
Date: Wed, 15 Mar 2023 10:48:20 +0000 (+0000)
Subject: file: Correctly fail PIE test
X-Git-Tag: 0.9.29~315
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=22e696bd7524086129730bfaffbe5520ca4d3fbf;p=pakfire.git

file: Correctly fail PIE test

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/libpakfire/file.c b/src/libpakfire/file.c
index 3701aecb0..99130a4b3 100644
--- a/src/libpakfire/file.c
+++ b/src/libpakfire/file.c
@@ -1761,12 +1761,15 @@ static int pakfire_file_hardening_check_pie(struct pakfire_file* file) {
 	switch (pakfire_file_get_elf_type(file)) {
 		// Shared Object files are good
 		case ET_DYN:
-			return 0;
+			break;
 
 		// Everything else is bad
 		default:
-			return 1;
+			file->hardening_issues |= PAKFIRE_FILE_NO_PIE;
+			break;
 	}
+
+	return 0;
 }
 
 static int __pakfire_file_hardening_check_execstack(