From: Tobin C. Harding <me@tobin.cc>
Date: Thu, 1 Mar 2018 21:42:59 +0000 (+1100)
Subject: leaking_addresses: explicitly name variable used in regex
X-Git-Tag: v4.17-rc1~87^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2306a67745ebdf3f98bc954248b74a3f1d57cdc2;p=thirdparty%2Fkernel%2Fstable.git

leaking_addresses: explicitly name variable used in regex

Currently sub routine may_leak_address() is checking regex against Perl
special variable $_ which is _fortunately_ being set correctly in a loop
before this sub routine is called.  We already have declared a variable
to hold this value '$line' we should use it.

Use $line in regex match instead of implicit $_

Signed-off-by: Tobin C. Harding <me@tobin.cc>
---

diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
index ce3b9d5a5bbc5..ba5f9709bcedc 100755
--- a/scripts/leaking_addresses.pl
+++ b/scripts/leaking_addresses.pl
@@ -363,7 +363,7 @@ sub may_leak_address
 	}
 
 	$address_re = get_address_re();
-	while (/($address_re)/g) {
+	while ($line =~ /($address_re)/g) {
 		if (!is_false_positive($1)) {
 			return 1;
 		}