From: Konfekt Date: Fri, 20 Dec 2024 18:41:02 +0000 (+0100) Subject: runtime(netrw): do not double escape Vim special characters X-Git-Tag: v9.1.0950~1 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2328a39a54fbd75576769193d7ff1ed2769e2ff9;p=thirdparty%2Fvim.git runtime(netrw): do not double escape Vim special characters This double escaping was likely introduced because it was the only way to make :Open work with hashes/percent signs despite shellescape(..., 1) supposedly taking care of it, but then breaks the gx mapping on MSYS2 as reported at [0] Since special characters in the URL following :Open can be escaped, whereas gx simply breaks and is more common, no longer double escape [0]: https://github.com/vim/vim/issues/16252 fixes: #16252 closes: #16265 Signed-off-by: Konfekt Signed-off-by: Christian Brabandt --- diff --git a/runtime/autoload/netrw.vim b/runtime/autoload/netrw.vim index c6af6ca4ba..96cfdb6001 100644 --- a/runtime/autoload/netrw.vim +++ b/runtime/autoload/netrw.vim @@ -5200,8 +5200,7 @@ fun! netrw#BrowseX(fname,remote) endif endif - " although shellescape(..., 1) is used in netrw#Open(), it's insufficient - call netrw#Open(escape(fname, '#%')) + call netrw#Open(fname) " cleanup: remove temporary file, " delete current buffer if success with handler,