From: Willy Tarreau <w@1wt.eu>
Date: Wed, 7 Aug 2024 13:35:30 +0000 (+0200)
Subject: MINOR: mux-h2/trace: add a state trace on stream creation/destruction
X-Git-Tag: v3.1-dev5~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=23417ab9d4bd03f74a05fad92b574f50f4660a9f;p=thirdparty%2Fhaproxy.git

MINOR: mux-h2/trace: add a state trace on stream creation/destruction

Logging below the developer level doesn't always yield very convenient
traces as we don't know well where streams are allocated nor released.
Let's just make that more explicit by using state-level traces for these
important steps.
---

diff --git a/src/mux_h2.c b/src/mux_h2.c
index d8e1850388..c8d588f50f 100644
--- a/src/mux_h2.c
+++ b/src/mux_h2.c
@@ -1556,6 +1556,7 @@ static inline void h2s_close(struct h2s *h2s)
 {
 	if (h2s->st != H2_SS_CLOSED) {
 		TRACE_ENTER(H2_EV_H2S_END, h2s->h2c->conn, h2s);
+		TRACE_STATE("releasing H2 stream", H2_EV_H2S_NEW, h2s->h2c->conn, h2s);
 		h2s->h2c->nb_streams--;
 		if (!h2s->id)
 			h2s->h2c->nb_reserved--;
@@ -1757,6 +1758,8 @@ static struct h2s *h2c_frt_stream_new(struct h2c *h2c, int id, struct buffer *in
 	/* OK done, the stream lives its own life now */
 	if (h2_frt_has_too_many_sc(h2c))
 		h2c->flags |= H2_CF_DEM_TOOMANY;
+
+	TRACE_STATE("created new H2 front stream", H2_EV_H2S_NEW, h2c->conn, h2s);
 	TRACE_LEAVE(H2_EV_H2S_NEW, h2c->conn);
 	return h2s;
 
@@ -1814,6 +1817,7 @@ static struct h2s *h2c_bck_stream_new(struct h2c *h2c, struct stconn *sc, struct
 		se_fl_set(h2s->sd, SE_FL_MAY_FASTFWD_CONS);
 	/* on the backend we can afford to only count total streams upon success */
 	h2c->stream_cnt++;
+	TRACE_STATE("created new H2 back stream", H2_EV_H2S_NEW, h2c->conn, h2s);
 
  out:
 	if (likely(h2s))