From: mkanat%bugzilla.org <>
Date: Wed, 24 Dec 2008 19:11:14 +0000 (+0000)
Subject: Bug 347707: Changing parameters could silently fail because we weren't correctly
X-Git-Tag: bugzilla-2.22.7~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=234cf4f73e81b902269fc9c0a2fb98e74b25edf9;p=thirdparty%2Fbugzilla.git

Bug 347707: Changing parameters could silently fail because we weren't correctly
 checking the return code from "rename"
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=justdave, a=mkanat
---

diff --git a/Bugzilla/Config.pm b/Bugzilla/Config.pm
index 3ee7da2fce..ba44f58a58 100644
--- a/Bugzilla/Config.pm
+++ b/Bugzilla/Config.pm
@@ -319,7 +319,7 @@ sub WriteParams {
     close $fh;
 
     rename $tmpname, "$datadir/params"
-      || die "Can't rename $tmpname to $datadir/params: $!";
+      or die "Can't rename $tmpname to $datadir/params: $!";
 
     ChmodDataFile("$datadir/params", 0666);
 }