From: Michael Schroeder <mls@suse.de>
Date: Thu, 23 Nov 2023 14:08:02 +0000 (+0100)
Subject: Further optimize dirpool caching in repo_write
X-Git-Tag: 0.7.27~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2373713eaad6c71bc282becc41d98b3f738127ae;p=thirdparty%2Flibsolv.git

Further optimize dirpool caching in repo_write

This halves the time to convert the rawhide/Everything repo.
---

diff --git a/src/repo_write.c b/src/repo_write.c
index c5e38dec..c965a76e 100644
--- a/src/repo_write.c
+++ b/src/repo_write.c
@@ -266,6 +266,8 @@ struct extdata {
   int len;
 };
 
+#define DIRIDCACHE_SIZE 1024
+
 struct cbdata {
   Pool *pool;
   Repo *repo;
@@ -301,7 +303,7 @@ struct cbdata {
   Id lastdirid;		/* last dir id seen in this repodata */
   Id lastdirid_own;	/* last dir id put in own pool */
 
-  Id diridcache[3 * 256];
+  Id diridcache[3 * DIRIDCACHE_SIZE];
 };
 
 #define NEEDID_BLOCK 1023
@@ -566,15 +568,29 @@ putinownpool(struct cbdata *cbdata, Repodata *data, Id id)
 static Id
 putinowndirpool_slow(struct cbdata *cbdata, Repodata *data, Dirpool *dp, Id dir)
 {
-  Id compid, parent;
+  Id compid, parent, id;
+  Id *cacheent;
 
   parent = dirpool_parent(dp, dir);
   if (parent)
-    parent = putinowndirpool_slow(cbdata, data, dp, parent);
+    {
+      /* put parent in own pool first */
+      cacheent = cbdata->diridcache + (parent & (DIRIDCACHE_SIZE - 1));
+      if (cacheent[0] == parent && cacheent[DIRIDCACHE_SIZE] == data->repodataid)
+        parent = cacheent[2 * DIRIDCACHE_SIZE];
+      else
+        parent = putinowndirpool_slow(cbdata, data, dp, parent);
+    }
   compid = dirpool_compid(dp, dir);
   if (cbdata->ownspool && compid > 1 && (!cbdata->clonepool || data->localpool))
     compid = putinownpool(cbdata, data, compid);
-  return dirpool_add_dir(cbdata->owndirpool, parent, compid, 1);
+  id = dirpool_add_dir(cbdata->owndirpool, parent, compid, 1);
+  /* cache result */
+  cacheent = cbdata->diridcache + (dir & (DIRIDCACHE_SIZE - 1));
+  cacheent[0] = dir;
+  cacheent[DIRIDCACHE_SIZE] = data->repodataid;
+  cacheent[2 * DIRIDCACHE_SIZE] = id;
+  return id;
 }
 
 static inline Id
@@ -583,14 +599,11 @@ putinowndirpool(struct cbdata *cbdata, Repodata *data, Id dir)
   Id *cacheent;
   if (dir && dir == cbdata->lastdirid)
     return cbdata->lastdirid_own;
-  cacheent = cbdata->diridcache + (dir & 255);
-  if (dir && cacheent[0] == dir && cacheent[256] == data->repodataid)
-    return cacheent[512];
+  cacheent = cbdata->diridcache + (dir & (DIRIDCACHE_SIZE - 1));
+  if (dir && cacheent[0] == dir && cacheent[DIRIDCACHE_SIZE] == data->repodataid)
+    return cacheent[2 * DIRIDCACHE_SIZE];
   cbdata->lastdirid = dir;
   cbdata->lastdirid_own = putinowndirpool_slow(cbdata, data, &data->dirpool, dir);
-  cacheent[0] = dir;
-  cacheent[256] = data->repodataid;
-  cacheent[512] = cbdata->lastdirid_own;
   return cbdata->lastdirid_own;
 }