From: Pauli Date: Wed, 28 Apr 2021 01:25:52 +0000 (+1000) Subject: test: never run fipsinstall if the tests are not enabled. X-Git-Tag: openssl-3.0.0-alpha16~99 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2395ad8079bdc76790a004f9aaeb53ef0b1c8df8;p=thirdparty%2Fopenssl.git test: never run fipsinstall if the tests are not enabled. Fixes #15056 The dependency for fipsinstall was being added to the makefile regardless of it being used. This means that a subsequent `make test` would fail if the command line application wasn't present. Rather than fix the instance in question, it is better to leave out this part of the makefile if the tests cannot be run. Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/15057) --- diff --git a/providers/build.info b/providers/build.info index 4296aa05a6b..b772e5ec250 100644 --- a/providers/build.info +++ b/providers/build.info @@ -147,11 +147,13 @@ IF[{- !$disabled{fips} -}] # module installation. We have the output go to standard output, because # the generated commands in build templates are expected to catch that, # and thereby keep control over the exact output file location. - DEPEND[|tests|]=fipsmodule.cnf - GENERATE[fipsmodule.cnf]=../apps/openssl fipsinstall \ - -module providers/$(FIPSMODULENAME) -provider_name fips \ - -mac_name HMAC -section_name fips_sect - DEPEND[fipsmodule.cnf]=$FIPSGOAL + IF[{- !$disabled{tests} -}] + DEPEND[|tests|]=fipsmodule.cnf + GENERATE[fipsmodule.cnf]=../apps/openssl fipsinstall \ + -module providers/$(FIPSMODULENAME) -provider_name fips \ + -mac_name HMAC -section_name fips_sect + DEPEND[fipsmodule.cnf]=$FIPSGOAL + ENDIF ENDIF #