From: Sean Christopherson Date: Thu, 23 Apr 2026 14:54:18 +0000 (-0700) Subject: x86/bug: Put HAVE_ARCH_BUG_FORMAT_ARGS WARN definitions inside __ASSEMBLER__ X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=23aea3c539a62ab97ca3aecf41d590d91f2911fc;p=thirdparty%2Flinux.git x86/bug: Put HAVE_ARCH_BUG_FORMAT_ARGS WARN definitions inside __ASSEMBLER__ Extend the !assembly #ifdef guarding x86's custom WARN helpers to cover the WARN macros themselves, as they aren't assembly friendly. This helps make it clear that things like __WARN_validate_printf() don't need a dummy definition for assembly code. No functional change intended. Suggested-by: Yan Zhao Signed-off-by: Sean Christopherson Signed-off-by: Dave Hansen Link: https://patch.msgid.link/20260423145419.459988-3-seanjc@google.com --- diff --git a/arch/x86/include/asm/bug.h b/arch/x86/include/asm/bug.h index bf3c802654d18..23ab054382695 100644 --- a/arch/x86/include/asm/bug.h +++ b/arch/x86/include/asm/bug.h @@ -154,7 +154,6 @@ struct arch_va_list { }; extern void *__warn_args(struct arch_va_list *args, struct pt_regs *regs); static __always_inline __printf(1, 2) void __WARN_validate_printf(const char *fmt, ...) { } -#endif /* __ASSEMBLER__ */ #define __WARN_bug_entry(flags, format) ({ \ struct bug_entry *bug; \ @@ -189,6 +188,7 @@ do { \ } \ __ret_warn_on; \ }) +#endif /* __ASSEMBLER__ */ #endif /* HAVE_ARCH_BUG_FORMAT_ARGS */