From: Michihiro NAKAJIMA <ggcueroad@gmail.com>
Date: Mon, 9 Nov 2009 07:21:54 +0000 (-0500)
Subject: Although the value stored to 'p' is used in the enclosing expression,
X-Git-Tag: v2.8.0~194
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=23f97d036da5b4c1c7931b975c669616bc9a4259;p=thirdparty%2Flibarchive.git

Although the value stored to 'p' is used in the enclosing expression,
the value is never actually read from 'p'

Found by Clang Static Analyzer.

SVN-Revision: 1621
---

diff --git a/libarchive/archive_read_support_format_raw.c b/libarchive/archive_read_support_format_raw.c
index 44b0aa0fb..9f538e0e6 100644
--- a/libarchive/archive_read_support_format_raw.c
+++ b/libarchive/archive_read_support_format_raw.c
@@ -89,9 +89,8 @@ archive_read_support_format_raw(struct archive *_a)
 static int
 archive_read_format_raw_bid(struct archive_read *a)
 {
-	const char *p;
 
-	if ((p = __archive_read_ahead(a, 1, NULL)) == NULL)
+	if (__archive_read_ahead(a, 1, NULL) == NULL)
 		return (-1);
 	return (1);
 }