From: Luca Ceresoli Date: Thu, 23 Apr 2026 11:53:28 +0000 (+0200) Subject: drm/rockchip: lvds: remove now-redundant call to drm_connector_attach_encoder() X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=24202edb689ead20411568251792a31103b9bde0;p=thirdparty%2Fkernel%2Flinux.git drm/rockchip: lvds: remove now-redundant call to drm_connector_attach_encoder() drm_connector_attach_encoder() is now called by drm_bridge_connector_init(). Reviewed-by: Dmitry Baryshkov Link: https://patch.msgid.link/20260423115334.444750-1-luca.ceresoli@bootlin.com Signed-off-by: Luca Ceresoli --- diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c index 75f898a10cbc2..7a0c4fa29f2f0 100644 --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c @@ -628,12 +628,6 @@ static int rockchip_lvds_bind(struct device *dev, struct device *master, ret = PTR_ERR(connector); goto err_free_bridge; } - - ret = drm_connector_attach_encoder(connector, encoder); - if (ret < 0) { - drm_err(drm_dev, "failed to attach encoder: %d\n", ret); - goto err_free_bridge; - } } pm_runtime_enable(dev);