From: Peter Krempa Date: Fri, 21 Jul 2023 07:51:06 +0000 (+0200) Subject: qemuValidateDomainVCpuTopology: Remove misconfiguration warning X-Git-Tag: v9.7.0-rc1~32 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=24310b2b7f1525398467cbb7c3ae6a4c1b8a48df;p=thirdparty%2Flibvirt.git qemuValidateDomainVCpuTopology: Remove misconfiguration warning Since commit baca59a5384 the NUMA definition is automatically fixed if the vCPU count mismatches the NUMA cpu count so that this warning will never be triggered. Additionally VIR_WARN of a misconfiguration of a VM would not really be seen in most cases as it's only simply logged. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 6e4976962d..797caf6076 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -761,7 +761,6 @@ qemuValidateDomainVCpuTopology(const virDomainDef *def, virQEMUCaps *qemuCaps) def->os.machine); unsigned int topologycpus; unsigned int granularity; - unsigned int numacpus; if (virDomainDefGetVcpus(def) == 0) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", @@ -785,13 +784,6 @@ qemuValidateDomainVCpuTopology(const virDomainDef *def, virQEMUCaps *qemuCaps) } } - numacpus = virDomainNumaGetCPUCountTotal(def->numa); - if ((numacpus != 0) && (topologycpus != numacpus)) { - VIR_WARN("CPU topology doesn't match numa CPU count; " - "partial NUMA mapping is obsoleted and will " - "be removed in future"); - } - /* vCPU hotplug granularity must be respected */ granularity = qemuValidateDefGetVcpuHotplugGranularity(def); if ((virDomainDefGetVcpus(def) % granularity) != 0) {