From: Stefan Metzmacher Date: Mon, 21 Feb 2022 22:39:14 +0000 (+0100) Subject: s4:libnet: sdb_free_entry() already clears everything X-Git-Tag: tevent-0.12.0~336 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=244e188083ae006120014049e3673bb960a15080;p=thirdparty%2Fsamba.git s4:libnet: sdb_free_entry() already clears everything There's no need to know about '.free_entry'. Signed-off-by: Stefan Metzmacher Reviewed-by: Andrew Bartlett --- diff --git a/source4/libnet/libnet_export_keytab.c b/source4/libnet/libnet_export_keytab.c index 580281a2062..ca76477f329 100644 --- a/source4/libnet/libnet_export_keytab.c +++ b/source4/libnet/libnet_export_keytab.c @@ -34,9 +34,7 @@ static NTSTATUS sdb_kt_copy(TALLOC_CTX *mem_ctx, const char *principal, const char **error_string) { - struct sdb_entry_ex sentry = { - .free_entry = NULL, - }; + struct sdb_entry_ex sentry = {}; krb5_keytab keytab; krb5_error_code code = 0; NTSTATUS status = NT_STATUS_UNSUCCESSFUL; @@ -93,9 +91,6 @@ static NTSTATUS sdb_kt_copy(TALLOC_CTX *mem_ctx, if (sentry.entry.keys.len == 0) { SAFE_FREE(entry_principal); sdb_free_entry(&sentry); - sentry = (struct sdb_entry_ex) { - .free_entry = NULL, - }; continue; } @@ -136,9 +131,6 @@ static NTSTATUS sdb_kt_copy(TALLOC_CTX *mem_ctx, SAFE_FREE(entry_principal); sdb_free_entry(&sentry); - sentry = (struct sdb_entry_ex) { - .free_entry = NULL, - }; } if (code != 0 && code != SDB_ERR_NOENTRY) {