From: John Ferlan <jferlan@redhat.com>
Date: Thu, 11 Sep 2014 21:52:58 +0000 (-0400)
Subject: libxl: Resolve Coverity CHECKED_RETURN
X-Git-Tag: CVE-2014-3633~69
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=245134fc1df467ce75df2e5181ec12f497aba5f8;p=thirdparty%2Flibvirt.git

libxl: Resolve Coverity CHECKED_RETURN

Add a check of the return for virDomainHostdevInsert() like every
other call.

Signed-off-by: John Ferlan <jferlan@redhat.com>
---

diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index 17d6257bf4..2f2c590ee9 100644
--- a/src/libxl/libxl_driver.c
+++ b/src/libxl/libxl_driver.c
@@ -2891,7 +2891,8 @@ libxlDomainAttachDeviceConfig(virDomainDefPtr vmdef, virDomainDeviceDefPtr dev)
                 return -1;
             }
 
-            virDomainHostdevInsert(vmdef, hostdev);
+            if (virDomainHostdevInsert(vmdef, hostdev) < 0)
+                return -1;
             break;
 
         default: