From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 11 Jul 2025 09:26:28 +0000 (+0200)
Subject: dns: Fix a clang-tidy warning
X-Git-Tag: rec-5.4.0-alpha0~36^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=24570745905593be704ceaa990ecaa442d842d95;p=thirdparty%2Fpdns.git

dns: Fix a clang-tidy warning

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
---

diff --git a/pdns/dns.cc b/pdns/dns.cc
index ed17a5f8e6..768a126fa6 100644
--- a/pdns/dns.cc
+++ b/pdns/dns.cc
@@ -88,7 +88,7 @@ std::string RCode::to_short_s(uint8_t rcode) {
 
 std::optional<uint8_t> RCode::from_short(const std::string_view& rcode_string)
 {
-  auto position = std::find(rcodes_short_s.begin(), rcodes_short_s.end(), rcode_string);
+  const auto* position = std::find(rcodes_short_s.begin(), rcodes_short_s.end(), rcode_string);
   if (position == rcodes_short_s.end()) {
     return std::nullopt;
   }