From: Ben Darnell <ben@bendarnell.com>
Date: Thu, 9 Feb 2023 21:55:49 +0000 (+0000)
Subject: wsgi: Add barrier-based test for executor support
X-Git-Tag: v6.3.0b1~9^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=24603b44ebbe8c13eb927f22f8937a1ebcd109fe;p=thirdparty%2Ftornado.git

wsgi: Add barrier-based test for executor support
---

diff --git a/tornado/test/wsgi_test.py b/tornado/test/wsgi_test.py
index 96fc294bc..268620921 100644
--- a/tornado/test/wsgi_test.py
+++ b/tornado/test/wsgi_test.py
@@ -1,34 +1,82 @@
+import asyncio
 import concurrent.futures
+import threading
 
 from wsgiref.validate import validator
 
-from tornado.testing import AsyncHTTPTestCase
+from tornado.routing import RuleRouter
+from tornado.testing import AsyncHTTPTestCase, gen_test
 from tornado.wsgi import WSGIContainer
 
 
 class WSGIAppMixin:
-    def wsgi_app(self, environ, start_response):
+    # TODO: Now that WSGIAdapter is gone, this is a pretty weak test.
+    def get_executor(self):
+        raise NotImplementedError()
+
+    def get_app(self):
+        executor = self.get_executor()
+        # The barrier test in DummyExecutorTest will always wait the full
+        # value of this timeout, so we don't want it to be too high.
+        self.barrier = threading.Barrier(2, timeout=0.3)
+
+        def make_container(app):
+            return WSGIContainer(validator(app), executor=executor)
+
+        return RuleRouter(
+            [
+                ("/simple", make_container(self.simple_wsgi_app)),
+                ("/barrier", make_container(self.barrier_wsgi_app)),
+            ]
+        )
+
+    def respond_plain(self, start_response):
         status = "200 OK"
         response_headers = [("Content-Type", "text/plain")]
         start_response(status, response_headers)
-        return [b"Hello world!"]
 
-
-class WSGIContainerTest(WSGIAppMixin, AsyncHTTPTestCase):
-    # TODO: Now that WSGIAdapter is gone, this is a pretty weak test.
-    def get_app(self):
-        return WSGIContainer(validator(self.wsgi_app))
+    def simple_wsgi_app(self, environ, start_response):
+        self.respond_plain(start_response)
+        return [b"Hello world!"]
 
     def test_simple(self):
-        response = self.fetch("/")
+        response = self.fetch("/simple")
         self.assertEqual(response.body, b"Hello world!")
 
+    def barrier_wsgi_app(self, environ, start_response):
+        self.respond_plain(start_response)
+        try:
+            n = self.barrier.wait()
+        except threading.BrokenBarrierError:
+            return [b"broken barrier"]
+        else:
+            return [b"ok %d" % n]
+
+
+class WSGIContainerDummyExecutorTest(WSGIAppMixin, AsyncHTTPTestCase):
+    def get_executor(self):
+        return None
+
+    @gen_test
+    async def test_concurrent_barrier(self):
+        self.barrier.reset()
+        resps = await asyncio.gather(
+            self.http_client.fetch(self.get_url("/barrier")),
+            self.http_client.fetch(self.get_url("/barrier")),
+        )
+        for resp in resps:
+            self.assertEqual(resp.body, b"broken barrier")
+
 
 class WSGIContainerThreadPoolTest(WSGIAppMixin, AsyncHTTPTestCase):
-    def get_app(self):
-        executor = concurrent.futures.ThreadPoolExecutor()
-        return WSGIContainer(validator(self.wsgi_app), executor)
+    def get_executor(self):
+        return concurrent.futures.ThreadPoolExecutor()
 
-    def test_simple(self):
-        response = self.fetch("/")
-        self.assertEqual(response.body, b"Hello world!")
+    @gen_test
+    async def test_concurrent_barrier(self):
+        self.barrier.reset()
+        resps = await asyncio.gather(
+            self.http_client.fetch(self.get_url("/barrier")),
+            self.http_client.fetch(self.get_url("/barrier")),
+        )
+        self.assertEqual([b"ok 0", b"ok 1"], sorted([resp.body for resp in resps]))