From: Kern Sibbald <kern@sibbald.com>
Date: Mon, 29 Jun 2020 12:46:56 +0000 (+0200)
Subject: Eliminate compiler errors when smartalloc is turned off
X-Git-Tag: Release-11.3.2~1424
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2489939ff2f2b32667e286c96ce37cd0f8e9d12a;p=thirdparty%2Fbacula.git

Eliminate compiler errors when smartalloc is turned off
---

diff --git a/bacula/src/dird/dird_conf.h b/bacula/src/dird/dird_conf.h
index 881d113c01..a3f26a4615 100644
--- a/bacula/src/dird/dird_conf.h
+++ b/bacula/src/dird/dird_conf.h
@@ -255,7 +255,7 @@ inline char *CAT::name() const { return hdr.name; }
 class CLIENT_GLOBALS {
 public:
    dlink link;                        /* double link */
-   const char *name;                  /* resource name */
+   char *name;                        /* resource name */
    int32_t NumConcurrentJobs;         /* number of concurrent jobs running */
    char *SetIPaddress;                /* address from SetIP command */
    int enabled;                       /* -1: not set, 0 disabled, 1 enabled */
@@ -318,7 +318,7 @@ inline char *CLIENT::name() const { return hdr.name; }
 class STORE_GLOBALS {
 public:
    dlink link;                        /* double link */
-   const char *name;                  /* resource name */
+   char *name;                        /* resource name */
    int32_t NumConcurrentJobs;         /* number of concurrent jobs running */
    int32_t NumConcurrentReadJobs;     /* number of concurrent read jobs running */
    int enabled;                       /* -1: not set, 0: disabled, 1: enabled */
@@ -420,7 +420,7 @@ inline void USTORE::set_source(const char *where)
 class JOB_GLOBALS {
 public:
    dlink link;                        /* double link */
-   const char *name;                  /* resource name */
+   char *name;                        /* resource name */
    int32_t NumConcurrentJobs;         /* number of concurrent jobs running */
    int enabled;                       /* -1: disabled, 0: disabled, 1: Enabled */
 };
@@ -623,7 +623,7 @@ inline char *FILESET::name() const { return hdr.name; }
 class SCHED_GLOBALS {
 public:
    dlink link;                        /* double link */
-   const char *name;                  /* resource name */
+   char *name;                        /* resource name */
    int enabled;                       /* -1: not set, 0: disabled, 1: Enabled */
 };
 
diff --git a/bacula/src/lib/smartall.h b/bacula/src/lib/smartall.h
index 43a314f351..40bfc8e513 100644
--- a/bacula/src/lib/smartall.h
+++ b/bacula/src/lib/smartall.h
@@ -30,14 +30,13 @@ extern uint64_t DLL_IMP_EXP sm_bytes;
 extern uint32_t DLL_IMP_EXP sm_max_buffers;
 extern uint32_t DLL_IMP_EXP sm_buffers;
 
+/* Avoid aggressive GCC optimization */
+extern void *bmemset(void *s, int c, size_t n);
+
 #ifdef  SMARTALLOC
 #undef  SMARTALLOC
 #define SMARTALLOC SMARTALLOC
 
-
-/* Avoid aggressive GCC optimization */
-extern void *bmemset(void *s, int c, size_t n);
-
 extern void *sm_malloc(const char *fname, int lineno, unsigned int nbytes),
             *sm_calloc(const char *fname, int lineno,
                 unsigned int nelem, unsigned int elsize),
@@ -84,7 +83,7 @@ inline void sm_dump(int x, int y=0) {} /* with default arguments, we can't use a
 #define sm_new_owner(a, b, c)
 #define sm_get_owner(a,b)
 #define sm_malloc(f, l, n)     malloc(n)
-#define sm_free(f, l, n)       free(n)
+#define sm_free(f, l, n)       free((void *)n)
 #define sm_check(f, l, fl)
 #define sm_check_rtn(f, l, fl) 1
 
diff --git a/bacula/src/stored/cloud_transfer_mgr.h b/bacula/src/stored/cloud_transfer_mgr.h
index f14375ce6a..a59bc987ab 100644
--- a/bacula/src/stored/cloud_transfer_mgr.h
+++ b/bacula/src/stored/cloud_transfer_mgr.h
@@ -111,8 +111,8 @@ public:
    bool                 m_debug_retry;
 
    /* variables */
-   const char          *m_cache_fname;
-   const char          *m_volume_name;
+   char                *m_cache_fname;
+   char                *m_volume_name;
    uint32_t             m_part;
    cloud_driver        *m_driver;
    DCR                 *m_dcr;