From: John Wolfe <jwolfe@vmware.com>
Date: Fri, 11 Sep 2020 19:11:02 +0000 (-0700)
Subject: Fix a stack-use-after-scope issue in FileLockScanDirectory.
X-Git-Tag: stable-11.2.0~58
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=248ef2c5361a0a8a7e4bed9cafec50598a313899;p=thirdparty%2Fopen-vm-tools.git

Fix a stack-use-after-scope issue in FileLockScanDirectory.
---

diff --git a/open-vm-tools/lib/file/fileLockPrimitive.c b/open-vm-tools/lib/file/fileLockPrimitive.c
index b83f391b8..f2054f09e 100644
--- a/open-vm-tools/lib/file/fileLockPrimitive.c
+++ b/open-vm-tools/lib/file/fileLockPrimitive.c
@@ -755,6 +755,7 @@ FileLockScanDirectory(const char *lockDir,      // IN:
       LockValues *ptr;
       Bool       myLockFile;
       LockValues memberValues;
+      char buffer[FILELOCK_DATA_SIZE];
 
       if ((fileList[i] == NULL) || (*fileList[i] == 'E')) {
          continue;
@@ -767,8 +768,6 @@ FileLockScanDirectory(const char *lockDir,      // IN:
          /* It's me! No need to read or validate anything. */
          ptr = myValues;
       } else {
-         char buffer[FILELOCK_DATA_SIZE];
-
          /* It's not me! Attempt to extract the member values. */
          err = FileLockMemberValues(lockDir, fileList[i], buffer,
                                     FILELOCK_DATA_SIZE, &memberValues);