From: Igor Putovny <igor.putovny@nic.cz>
Date: Tue, 9 Apr 2024 09:35:49 +0000 (+0200)
Subject: Add more assertions
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=24a450a817cd008b9dfc161760f8bf922fcbaa47;p=thirdparty%2Fbird.git

Add more assertions
---

diff --git a/proto/aggregator/aggregator.c b/proto/aggregator/aggregator.c
index 47e05f026..ac6f02cdc 100644
--- a/proto/aggregator/aggregator.c
+++ b/proto/aggregator/aggregator.c
@@ -297,12 +297,15 @@ first_pass(struct trie_node *node, slab *trie_slab)
 
   if (is_leaf(node))
   {
+    /*
     for (int i = 0; i < node->potential_buckets_count; i++)
     {
       if (node->potential_buckets[i] == node->bucket)
         return;
     }
+    */
 
+    assert(node->bucket != NULL);
     node->potential_buckets[node->potential_buckets_count++] = node->bucket;
     return;
   }
@@ -513,12 +516,14 @@ second_pass(struct trie_node *node)
   assert(node != NULL);
   assert(node->potential_buckets_count <= MAX_POTENTIAL_BUCKETS_COUNT);
 
-  if (node->parent == NULL)
-    assert(node->bucket != NULL);
+  //if (node->parent == NULL)
+    //assert(node->bucket != NULL);
 
   if (is_leaf(node))
   {
     assert(node->potential_buckets_count > 0);
+    assert(node->potential_buckets[0] != NULL);
+    assert(node->potential_buckets[0] == node->bucket);
     return;
   }
 
@@ -593,8 +598,8 @@ third_pass(struct trie_node *node)
   if (node == NULL)
     return;
 
-  if (node->parent == NULL)
-    assert(node->bucket != NULL);
+  //if (node->parent == NULL)
+    //assert(node->bucket != NULL);
 
   assert(node->potential_buckets_count <= MAX_POTENTIAL_BUCKETS_COUNT);
 
@@ -602,7 +607,8 @@ third_pass(struct trie_node *node)
   if (node->parent == NULL)
   {
     assert(node->potential_buckets_count > 0);
-    assert(node->bucket != NULL);
+    assert(node->potential_buckets[0] != NULL);
+    //assert(node->bucket != NULL);
     node->bucket = node->potential_buckets[0];
     goto descent;
   }