From: Jan Safranek <jsafrane@redhat.com>
Date: Mon, 12 Apr 2010 10:49:08 +0000 (+0200)
Subject: Use int for getopt() results
X-Git-Tag: v0.36~12
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=24e3eda3b0123fa0b156f8088a6e0fcc8624877e;p=thirdparty%2Flibcgroup.git

Use int for getopt() results

On ppc, char is unsigned and getopt()/getopt_long() returning -1 (= end of
arguments) is translated to 255 and results in 'Invalid command line option'.

Signed-off-by: Jan Safranek <jsafrane@redhat.com>
Signed-off-by: Dhaval Giani <dhaval.giani@gmail.com>
---

diff --git a/src/tools/cgcreate.c b/src/tools/cgcreate.c
index 616fa163..435df4a0 100644
--- a/src/tools/cgcreate.c
+++ b/src/tools/cgcreate.c
@@ -31,7 +31,7 @@ int main(int argc, char *argv[])
 {
 	int ret = 0;
 	int i, j;
-	char c;
+	int c;
 
 	/* Structure to get GID from group name */
 	struct group *grp = NULL;
diff --git a/src/tools/cgdelete.c b/src/tools/cgdelete.c
index af1cb7e6..7da6ab40 100644
--- a/src/tools/cgdelete.c
+++ b/src/tools/cgdelete.c
@@ -28,7 +28,7 @@ int main(int argc, char *argv[])
 {
 	int ret = 0;
 	int i, j;
-	char c;
+	int c;
 	int flags = 0;
 	int final_ret = 0;
 	int capacity = 0;
diff --git a/src/tools/cgexec.c b/src/tools/cgexec.c
index 6fec85a7..07af1990 100644
--- a/src/tools/cgexec.c
+++ b/src/tools/cgexec.c
@@ -43,7 +43,7 @@ int main(int argc, char *argv[])
 	uid_t uid;
 	gid_t gid;
 	pid_t pid;
-	char c;
+	int c;
 	struct cgroup_group_spec *cgroup_list[CG_HIER_MAX];
 
 	if (argc < 2) {