From: Kathleen King <kathleen.king@quentustech.com>
Date: Thu, 3 Jul 2014 19:12:22 +0000 (-0700)
Subject: Removed an autological-pointer-compare from src/switch_utils.c.
X-Git-Tag: v1.5.13~1^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=24e5c1328372705832b6313559b00ef821cc7749;p=thirdparty%2Ffreeswitch.git

Removed an autological-pointer-compare from src/switch_utils.c.

Building with Clang 3.5 gave the following warning: error: comparison
of array 'iface_out.sin6_addr.__in6_u.__u6_addr8' equal to a null
pointer is always false [-Werror,-Wtautological-pointer-compare]

This is a problem because as it is written the check will never be
true. A pointer to a structure within a structure will never be null. The
intention was either to null check the pointer or to check if the IP
address itself was not zero.

From context in the code this appeared to be a pointer null check so I
removed it.
---

diff --git a/src/switch_utils.c b/src/switch_utils.c
index a5c4b8f2f7..da0373098d 100644
--- a/src/switch_utils.c
+++ b/src/switch_utils.c
@@ -1560,10 +1560,6 @@ SWITCH_DECLARE(switch_status_t) switch_find_local_ip(char *buf, int len, int *ma
 				goto doh;
 			}
 
-			if (iface_out.sin6_addr.s6_addr == 0) {
-				goto doh;
-			}
-
 			inet_ntop(AF_INET6, (const void *) &iface_out.sin6_addr, buf, len - 1);
 			status = SWITCH_STATUS_SUCCESS;
 		}