From: Benjamin Berg Date: Thu, 30 Oct 2025 08:24:49 +0000 (+0100) Subject: common: Use signed return value for ieee802_11_defrag_mle_subelem X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=24e9eb8f14c5f509e965a04971e8d2f21cc5d7e2;p=thirdparty%2Fhostap.git common: Use signed return value for ieee802_11_defrag_mle_subelem The function returns -1 on error which is not a valid value for size_t. Fix this by returning ssize_t. Fixes: 88f7d4cedfea ("Helper function for defragmenting of Multi-Link element subelements") CC: Pooventhiran G Signed-off-by: Benjamin Berg --- diff --git a/src/common/ieee802_11_common.c b/src/common/ieee802_11_common.c index 320d586fc..5d1e02f81 100644 --- a/src/common/ieee802_11_common.c +++ b/src/common/ieee802_11_common.c @@ -3486,9 +3486,9 @@ struct wpabuf * ieee802_11_defrag(const u8 *data, size_t len, bool ext_elem) * of data, see IEEE Std 802.11be-2024, Figure 35-4 - Per-STA Profile subelement * fragmentation within a fragmented Multi-Link element. */ -size_t ieee802_11_defrag_mle_subelem(struct wpabuf *mlbuf, - const u8 *parent_subelem, - size_t *defrag_len) +ssize_t ieee802_11_defrag_mle_subelem(struct wpabuf *mlbuf, + const u8 *parent_subelem, + size_t *defrag_len) { u8 *buf, *pos, *end; size_t len, subelem_len; diff --git a/src/common/ieee802_11_common.h b/src/common/ieee802_11_common.h index 6a108ccf7..09bd0675a 100644 --- a/src/common/ieee802_11_common.h +++ b/src/common/ieee802_11_common.h @@ -382,9 +382,9 @@ int ieee802_edmg_is_allowed(struct ieee80211_edmg_config allowed, struct ieee80211_edmg_config requested); struct wpabuf * ieee802_11_defrag(const u8 *data, size_t len, bool ext_elem); -size_t ieee802_11_defrag_mle_subelem(struct wpabuf *mlbuf, - const u8 *parent_subelem, - size_t *defrag_len); +ssize_t ieee802_11_defrag_mle_subelem(struct wpabuf *mlbuf, + const u8 *parent_subelem, + size_t *defrag_len); const u8 * get_ml_ie(const u8 *ies, size_t len, u8 type); const u8 * get_basic_mle_mld_addr(const u8 *buf, size_t len); const u8 * get_basic_mle_eml_capa(const u8 *buf, size_t len);