From: Nenad Merdanovic <nmerdan@haproxy.com>
Date: Sun, 12 Mar 2017 21:01:35 +0000 (+0100)
Subject: BUG/MEDIUM: cli: Prevent double free in CLI ACL lookup
X-Git-Tag: v1.8-dev1~98
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=24f45d8e34797ed9c16ac3fa6d89f3eed435e706;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: cli: Prevent double free in CLI ACL lookup

The memory is released by cli_release_mlook, which also properly sets the
pointer to NULL. This was introduced with a big code reorganization
involving moving to the new keyword registration form in commit ad8be61c7.

This fix needs to be backported to 1.7.

Signed-off-by: Nenad Merdanovic <nmerdan@haproxy.com>
---

diff --git a/src/map.c b/src/map.c
index b6fce4df84..90deb08da7 100644
--- a/src/map.c
+++ b/src/map.c
@@ -524,7 +524,6 @@ static int cli_io_handler_map_lookup(struct appctx *appctx)
 
 	default:
 		appctx->st2 = STAT_ST_FIN;
-		free(appctx->ctx.map.chunk.str);
 		return 1;
 	}
 }