From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Sat, 21 May 2016 15:52:02 +0000 (+1200)
Subject: Fix icons loading speed.
X-Git-Tag: SQUID_3_5_20~11
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=24f52b285276a612996499d2e3368f30fe316dc5;p=thirdparty%2Fsquid.git

Fix icons loading speed.

Since trunk r14100 (Bug 3875: bad mimeLoadIconFile error handling), each
icon was read from disk and written to Store one character at a time. I
did not measure startup delays in production, but in debugging runs,
fixing this bug sped up icons loading from 1 minute to 4 seconds.
---

diff --git a/src/mime.cc b/src/mime.cc
index 73211cc3dc..a07564f802 100644
--- a/src/mime.cc
+++ b/src/mime.cc
@@ -430,7 +430,7 @@ MimeIcon::created(StoreEntry *newEntry)
         /* read the file into the buffer and append it to store */
         int n;
         char *buf = (char *)memAllocate(MEM_4K_BUF);
-        while ((n = FD_READ_METHOD(fd, buf, sizeof(*buf))) > 0)
+        while ((n = FD_READ_METHOD(fd, buf, 4096)) > 0)
             e->append(buf, n);
 
         file_close(fd);