From: Joshua Colp <jcolp@digium.com>
Date: Tue, 27 Jan 2015 11:47:57 +0000 (+0000)
Subject: res_parking: Fix crash due to race condition when unloading.
X-Git-Tag: 14.0.0-beta1~1291
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2504f97b01fa0fa1dfbfa9f8d9fd80e3a5376fe9;p=thirdparty%2Fasterisk.git

res_parking: Fix crash due to race condition when unloading.

There is currently a race condition when unloading the res_parking
module. Depending on the will of the universe the subscription
invocation may occur AFTER the module is unloaded. This is because
the module does NOT use stasis_unsubscribe_and_join when terminating
the subscription. It merely uses stasis_unsubscribe.

This change makes it use stasis_unsubscribe_and_join which is documented
for usage in this exact scenario.

AST-1520 #close

Review: https://reviewboard.asterisk.org/r/4375/
........

Merged revisions 431114 from http://svn.asterisk.org/svn/asterisk/branches/13


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@431115 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/res/parking/parking_manager.c b/res/parking/parking_manager.c
index 74b455928d..b9e46c7d50 100644
--- a/res/parking/parking_manager.c
+++ b/res/parking/parking_manager.c
@@ -689,7 +689,7 @@ int load_parking_manager(void)
 
 static void parking_manager_disable_stasis(void)
 {
-	parking_sub = stasis_unsubscribe(parking_sub);
+	parking_sub = stasis_unsubscribe_and_join(parking_sub);
 }
 
 void unload_parking_manager(void)